Feat/signer two phase commit impl #6319
Open
+893
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…e throughout Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
… into feat/signer-two-phase-commit-impl
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
hstove
previously approved these changes
Jul 31, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…lock Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/signer-two-phase-commit-impl
branch
from
bd04283 to
e304a48
Compare
… than Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
… wait for block commit at correct height Signed-off-by: Jacinta Ferrant <[email protected]>
…n block Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/signer-two-phase-commit-impl
branch
from
d46d4ec to
0375c72
Compare
hstove
previously approved these changes
Aug 5, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
Aug 5, 2025
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
reviewed
Aug 15, 2025
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
fdefelici
reviewed
Aug 18, 2025
|
|
||
| /// Used by get_block_pre_committers | ||
| static CREATE_BLOCK_PRE_COMMITS_BY_SIGHASH_INDEX: &str = r#" | ||
| CREATE INDEX idx_block_pre_commits_by_sighash ON block_pre_commits(signer_signature_hash); |
There was a problem hiding this comment.
I'm wondering if this index is really needed (and could be removed to save disk space).
Looking at our queries, they are already covered by the composite index created by the PRIMARY KEY (signer_signature_hash, signer_addr).
Since signer_signature_hash is the leftmost column of the primary key, it efficiently supports lookups like those in get_block_pre_committers(..) without requiring an extra index.
Did you find a scenario where the extra index might actually provide a benefit?
Comment on lines
+1007
to
+1016
| // Make sure the sender is part of our signing set | ||
| let is_valid_sender = self.signer_addresses.iter().any(|addr| { | ||
| // it only matters that the address hash bytes match | ||
| stacker_address.bytes() == addr.bytes() | ||
| }); | ||
|
|
||
| if !is_valid_sender { | ||
| debug!("{self}: Received pre-commit message from an unknown sender {stacker_address:?}. Will not store."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
sanity check:
Could this kind of control be applied to any message a Signer receives from another Signer?
If it makes sense, we might consider generalizing it by moving it into handle_event_match(..).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6099